-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Merge all contracts into one ABI #1033
Conversation
Note: We may want to add a test to see what happens when two contracts in different modules are compiled with the same name (This was a concern that was present in the previous implementation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's similar changes which would have to be made to the wasm crate here in order to be consistent.
My preference on this is that we remove support for compiling contracts in TS for now as we're going to be making too many breaking changes. @kobyhallx
Ideally we have this for offsite, so they can compile and make tests in typescript. Its not a hard condition and if it makes the lives of tooling folks hard we can find an alternative. I'm guessing the painpoint you are referring to is when we are developing on master since, once we cut a release the ts and native should be synced up? |
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
In that case we need to update |
…/noir into kw/serialize-contracts
Related issue(s)
Resolves #
Description
This:
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
Additional context